-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: resizable GET #9868
front: resizable GET #9868
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9868 +/- ##
==========================================
- Coverage 38.22% 38.17% -0.05%
==========================================
Files 995 996 +1
Lines 91910 91989 +79
Branches 1193 1194 +1
==========================================
- Hits 35128 35117 -11
- Misses 56327 56416 +89
- Partials 455 456 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
f6a6510
to
59a8ac2
Compare
59a8ac2
to
ec09858
Compare
ec09858
to
48cb311
Compare
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
Just so you know, I'll need to revert the change between I don't think this will impact this PR though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! this new wrapper will be very convenient for the speedspacechart too.
everything seems good apart from the problem related to @SharglutDev comment
48cb311
to
de76bd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
fix https://github.com/osrd-project/osrd-confidential/issues/872
depend on OpenRailAssociation/osrd-ui#728