Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: resizable GET #9868

Merged
merged 1 commit into from
Nov 28, 2024
Merged

front: resizable GET #9868

merged 1 commit into from
Nov 28, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Nov 26, 2024

@Wadjetz Wadjetz self-assigned this Nov 26, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Nov 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 122 lines in your changes missing coverage. Please review.

Project coverage is 38.17%. Comparing base (ab6cdbb) to head (de76bd4).
Report is 7 commits behind head on dev.

Files with missing lines Patch % Lines
front/src/common/ResizableSection.tsx 0.00% 47 Missing and 1 partial ⚠️
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 38 Missing ⚠️
...tdcm/components/StdcmResults/StdcmDebugResults.tsx 0.00% 23 Missing ⚠️
...WithSpaceTimeChart/ManchetteWithSpaceTimeChart.tsx 0.00% 8 Missing ⚠️
...nents/SpeedSpaceChart/SpeedSpaceChartContainer.tsx 0.00% 5 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #9868      +/-   ##
==========================================
- Coverage   38.22%   38.17%   -0.05%     
==========================================
  Files         995      996       +1     
  Lines       91910    91989      +79     
  Branches     1193     1194       +1     
==========================================
- Hits        35128    35117      -11     
- Misses      56327    56416      +89     
- Partials      455      456       +1     
Flag Coverage Δ
editoast 73.30% <ø> (-0.04%) ⬇️
front 20.16% <0.00%> (-0.03%) ⬇️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz added the module:stdcm Short-Term DCM label Nov 27, 2024
@Wadjetz Wadjetz force-pushed the ebe/front/get-resize-handle branch 3 times, most recently from f6a6510 to 59a8ac2 Compare November 27, 2024 09:33
@Wadjetz Wadjetz requested review from Math-R and Yohh November 27, 2024 09:33
@Wadjetz Wadjetz marked this pull request as ready for review November 27, 2024 10:14
@Wadjetz Wadjetz requested a review from a team as a code owner November 27, 2024 10:14
@Wadjetz Wadjetz changed the title front: resizable section and GET front: resizable GET Nov 27, 2024
Signed-off-by: Egor Berezovskiy <egor@berezify.fr>
@SharglutDev
Copy link
Contributor

Just so you know, I'll need to revert the change between min-height and height you made in this PR because of this :
image
min-height need to be kept.

I don't think this will impact this PR though.

Copy link
Contributor

@Yohh Yohh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! this new wrapper will be very convenient for the speedspacechart too.

everything seems good apart from the problem related to @SharglutDev comment

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Wadjetz Wadjetz added this pull request to the merge queue Nov 28, 2024
Merged via the queue into dev with commit a9e4a9b Nov 28, 2024
27 checks passed
@Wadjetz Wadjetz deleted the ebe/front/get-resize-handle branch November 28, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants