Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575 #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notes: [B] The display_printUsage() help text options really need to be more thoroughly tested, e.g. by people using non-us keyboards. |
|
On Tue, Jul 27, 2021 at 12:32 PM Ken Dickey ***@***.***> wrote:
Notes:
[A] Given the superannuated nature of the code, it would be good to
eliminate the ps2 mouse support and invert the logic so that the -DUSEEVDEV
guard was inverted so as to make this code path the default code. Then this
flag would no longer be required by the normal build. IMHO, this would be
less confusing.
If it works for you, go for it. You're the one driving fb-dev support
these days. Make it the way you want it.
… [B] The display_printUsage() help text options really need to be more
thoroughly tested, e.g. by people using non-us keyboards.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#576 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADY5VUELDOJTHIPCDSCWNSTTZ4CUHANCNFSM5A6442CQ>
.
--
_,,,^..^,,,_
best, Eliot
|
|
Elided USEEVDEV flag & fixes a few nits. Looks ready to integrate.. |
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Dec 25, 2021
…houldScan: ] KILLED by 1/10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
… method [ attemptToShrink ] 10 test cases.
hogoww
referenced
this pull request
in hogoww/opensmalltalk-vm
Feb 26, 2022
…method [ attemptToShrink ] 8/10 Test Cases are NOT EQUIVALENT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for bug:
Unable to rebind keyboard device in vm-display-fbdev (FrameBuffer) #575
Tested on arm32 Raspberry Pi 3 with Raspberry Pi OS (no X11)
and on arm64 Le Potato (AML-S905S-XX) with Armbian OS.
Nota Bene: The include file ordering fix for arm64 does not seem to have been applied yet to the 32 bit platform.