Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change toplo branch #195

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Change toplo branch #195

merged 4 commits into from
Jul 22, 2024

Conversation

labordep
Copy link
Member

No description provided.

@labordep labordep requested a review from Nyan11 July 18, 2024 14:38
@labordep labordep added the enhancement New feature or request label Jul 18, 2024
@labordep labordep added this to the alpha 5 milestone Jul 18, 2024
Copy link
Collaborator

@Nyan11 Nyan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current:

image

If We remove the Bloc and the Toplo dependance. (They are still in Toplo-Serialization and Bloc-Serialization):

image

If we choose the later, the Bloc-Serialization and the Toplo-Serialization will define the Bloc version and the Toplo version.
The later is less spaghetti but we do not have a direct knowledge of the Bloc and Toplo version

@Nyan11
Copy link
Collaborator

Nyan11 commented Jul 22, 2024

@labordep i suggest we merge. What do you think ?

@labordep
Copy link
Member Author

labordep commented Jul 22, 2024

@Nyan11 that's what I want: by default all dependencies manage here sub dependencies and the responsibility is dispatched in differents projects. If a project wants to change default branch it's its reponsibility to do that on top of the baseline.

@labordep
Copy link
Member Author

We can remove Bloc and Toplo dependencies.

@Nyan11 Nyan11 self-requested a review July 22, 2024 14:48
@labordep labordep merged commit 7073419 into main Jul 22, 2024
9 checks passed
@labordep labordep deleted the dev-baseline branch July 22, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants