Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set https as default iceberg selector #89

Merged
merged 1 commit into from
Sep 6, 2023
Merged

set https as default iceberg selector #89

merged 1 commit into from
Sep 6, 2023

Conversation

labordep
Copy link
Member

@labordep labordep commented Sep 6, 2023

No description provided.

@labordep
Copy link
Member Author

labordep commented Sep 6, 2023

@Nyan11 can you check if #87 is fixed ?

@labordep labordep requested a review from Nyan11 September 6, 2023 09:01
@Nyan11
Copy link
Collaborator

Nyan11 commented Sep 6, 2023

Yes, it's fix but it doesn't seem to affect time that much. (CI Window + Pharo 12 still take more than 10 minutes)

Nyan11
Nyan11 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@Nyan11 Nyan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@labordep labordep closed this Sep 6, 2023
@labordep labordep reopened this Sep 6, 2023
@labordep labordep merged commit 86c26e8 into main Sep 6, 2023
12 checks passed
@labordep labordep deleted the dev-ci branch September 6, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyan11 Nyan11 Nyan11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labordep @Nyan11