Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces #17

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
f9f34ae
chore: create function stubs
lars-reimann Mar 9, 2023
6d15654
feat: check whether string is python identifier or qualified name
lars-reimann Mar 9, 2023
fbbf45e
feat: `create_input_structure_tree`
lars-reimann Mar 9, 2023
72f9957
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 9, 2023
e55a00a
refactor: rename test functions and parameters to prevent shadowing o…
lars-reimann Mar 10, 2023
29994c1
feat: `concatenate_functions_tree`
lars-reimann Mar 10, 2023
4b07b8c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 10, 2023
e012b45
build: add flatten-dict as dependency to tox config
lars-reimann Mar 10, 2023
735ea37
feat: restrict `targets` in `create_input_structure_tree`
lars-reimann Mar 11, 2023
e3b95f6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 11, 2023
fe1ccad
Merge branch 'main' into namespaces
lars-reimann Mar 14, 2023
77d83e2
refactor: change `level_of_inputs` values to `"global"` and `"local"`
lars-reimann Mar 14, 2023
fb21b83
style: fix several lint errors
lars-reimann Mar 14, 2023
c0fb87a
style: fix more lint errors
lars-reimann Mar 14, 2023
94ef1f1
docs: add missing docstrings
lars-reimann Mar 14, 2023
afed405
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 14, 2023
c4136d7
refactor: rename `level_of_inputs` to `namespace_of_inputs`
lars-reimann Mar 14, 2023
9bdb692
Update src/dags/dag_tree.py
lars-reimann Mar 14, 2023
b4deb97
Update src/dags/dag_tree.py
lars-reimann Mar 14, 2023
463d18f
Update src/dags/dag_tree.py
lars-reimann Mar 14, 2023
9c73d12
test: `name_clashes` set to `"warn"`
lars-reimann Mar 17, 2023
e1d3401
docs: better examples
lars-reimann Mar 17, 2023
9fa37e8
test: more than 2 levels of nesting
lars-reimann Mar 17, 2023
f7e12ec
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 17, 2023
51dd3b1
feat: detect name clashes
lars-reimann Mar 17, 2023
d4078d0
test: `find_parent_child_name_clashes`
lars-reimann Mar 17, 2023
43173e8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 17, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ ipython_config.py
# VS Code
.vscode

# IntelliJ
.idea/

# pyenv
.python-version

Expand Down
4 changes: 4 additions & 0 deletions environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,3 +30,7 @@ dependencies:
# Development
- jupyterlab
- nbsphinx

# Pip
- pip:
- flatten-dict
4 changes: 4 additions & 0 deletions src/dags/__init__.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
from dags.dag import concatenate_functions
from dags.dag import get_ancestors
from dags.dag_tree import concatenate_functions_tree
from dags.dag_tree import create_input_structure_tree


__all__ = [
"concatenate_functions",
"concatenate_functions_tree",
"create_input_structure_tree",
"get_ancestors",
]
2 changes: 1 addition & 1 deletion src/dags/dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ def _create_arguments_of_concatenated_function(functions, dag):
dag (networkx.DiGraph): The complete DAG.

Returns:
inspect.Signature: The signature of the concatenated function.
list: The arguments of the concatenated function.

"""
function_names = set(functions)
Expand Down
Loading