Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't validate phone number uniqueness if nil #39

Merged
merged 1 commit into from
Jun 25, 2024
Merged

fix: don't validate phone number uniqueness if nil #39

merged 1 commit into from
Jun 25, 2024

Conversation

moustachu
Copy link
Member

The validation was preventing Decidim::User to be saved when the phone_number attribute is nil.

@Quentinchampenois Quentinchampenois merged commit c23334e into feature/half_signup_and_budgets_booth Jun 25, 2024
6 checks passed
Stef-Rousset
Stef-Rousset approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@Stef-Rousset Stef-Rousset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, thanks for the correction on the validation !

@moustachu moustachu mentioned this pull request Jun 25, 2024
Merged
@Quentinchampenois Quentinchampenois mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stef-Rousset Stef-Rousset Stef-Rousset approved these changes

@Quentinchampenois Quentinchampenois Quentinchampenois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moustachu @Quentinchampenois @Stef-Rousset