Enable additional sources for federated API #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to merge multiple collections source Allow to directly give a collection in the config
Ndpnt
changed the title
MattiSG
reviewed
Mar 27, 2024
src/services/collections.test.js
Outdated
| const COLLECTION_2_OVERRIDEN = { id: COLLECTION_2.id, name: 'Override Collection 2', endpoint: 'http://domain2.example/endpoint' }; | ||
|
|
||
| describe('removeDuplicatesKeepLatest', () => { | ||
| it('removes duplicates based on their id and keep the latest defined', () => { |
There was a problem hiding this comment.
Suggested change
| it('removes duplicates based on their id and keep the latest defined', () => { | |
| it('removes duplicates based on their id and keeps the latest defined', () => { |
MattiSG
reviewed
Mar 29, 2024
MattiSG
requested changes
Mar 29, 2024
MattiSG
reviewed
Mar 29, 2024
Merged
|
Replaced by #6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
collections.jsondata structure opentermsarchive.org#313federated-apiconfiguration docs#121