-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AAFReader: Added kind support for auxiliary AAF tracks (#28) #27
Conversation
Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 90.15% 90.15%
=======================================
Files 3 3
Lines 1107 1107
=======================================
Hits 998 998
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
# Timecode, Edgecode, others? | ||
result.kind = "" | ||
# Timecode, Edgecode, Data, ... | ||
result.kind = f"AAF_{media_kind}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, here are the DataDefs that drive the media kind that's used from @markreidvfx
Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
8c8864c
to
951e3af
Compare
@reinecke @markreidvfx added a test for this change. |
LGTM - But I'll let @markreidvfx have the final 👍 since he's more deeply familiar with the adapter. |
@markreidvfx any opinion on this? |
sorry for the delay. LGTM. Something to be aware of is that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From meeting discussion: everyone seems okay with landing this.
Fixes #28
Description
Makes sure non audio / video tracks get a
kind
string assigned. I added anAAF_
prefix, followed by the AAF track kind.