Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAFReader: Added kind support for auxiliary AAF tracks (#28) #27

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

timlehr
Copy link
Collaborator

@timlehr timlehr commented Nov 9, 2023

Fixes #28

Description

Makes sure non audio / video tracks get a kind string assigned. I added an AAF_ prefix, followed by the AAF track kind.

Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c480e0) 90.15% compared to head (951e3af) 90.15%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #27   +/-   ##
=======================================
  Coverage   90.15%   90.15%           
=======================================
  Files           3        3           
  Lines        1107     1107           
=======================================
  Hits          998      998           
  Misses        109      109           
Flag Coverage Δ
unittests 90.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
..._aaf_adapter/adapters/advanced_authoring_format.py 85.93% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Timecode, Edgecode, others?
result.kind = ""
# Timecode, Edgecode, Data, ...
result.kind = f"AAF_{media_kind}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, here are the DataDefs that drive the media kind that's used from @markreidvfx

Signed-off-by: Tim Lehr <tim.lehr@disneyanimation.com>
@timlehr timlehr changed the title Added kind support for auxiliary AAF tracks AAFReader: Added kind support for auxiliary AAF tracks Nov 11, 2023
@timlehr timlehr changed the title AAFReader: Added kind support for auxiliary AAF tracks AAFReader: Added kind support for auxiliary AAF tracks (#28) Nov 11, 2023
@timlehr
Copy link
Collaborator Author

timlehr commented Nov 11, 2023

@reinecke @markreidvfx added a test for this change.

@reinecke
Copy link
Member

LGTM - But I'll let @markreidvfx have the final 👍 since he's more deeply familiar with the adapter.

@timlehr
Copy link
Collaborator Author

timlehr commented Dec 9, 2023

@markreidvfx any opinion on this?

@markreidvfx
Copy link
Member

sorry for the delay. LGTM.

Something to be aware of is that media_kind could have spaces in it. I've seen it be inconsistent between AAF files, namely with the Descriptive Metadata media_kind for markers. This is would be more of issue for the AAF writer.

Copy link
Member

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From meeting discussion: everyone seems okay with landing this.

@jminor jminor merged commit aa1b184 into OpenTimelineIO:main Feb 1, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AAF Reader: Add support for non-AV track kinds
4 participants