Writer: Added pre- / post-transcribe hooks to facilitate media essence embedding #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
Requires #49
Requires change to OTIO core (for tests to pass):
AcademySoftwareFoundation/OpenTimelineIO#1711
Summarize your change.
This PR adds AAF adapter specific hooks that can be used to implement just-in-time transcoding of media for embedding purposes. It also adds the
embed_essence
argument to the write functionality, which will attempt to import media references. The newcreate_edgecode
argument allows to control if an edge code should be applied to the AAF. Only.wav
,.dnx
and.aaf
can be embedded. Thanks a lot @markreidvfx for your help with the embedding code.New hooks introduced:
otio_aaf_pre_write_transcribe
: useful for transcoding media for embeddingotio_aaf_post_write_transcribe
: useful for cleaning up in-memory timeline / reverting to original mediaotio_aaf_pre_read_transcribe
: useful to modify AAF structure in-memory before readotio_aaf_post_read_transcribe
: useful to extract media from AAF file post timeline transcriptionReference associated tests.
Draft PR since I'm missing a test for .aaf embedding still
tests/test_aaf_adapter.py