Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add media reference to inspector #68

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Add media reference to inspector #68

wants to merge 24 commits into from

Conversation

jspada200
Copy link

This is a Work-In-Progress Pull Request meant to solve: #62

Changes

Main Changes:

  • Add new section to inspector to view and modify Media References
  • Supports MissingMediaReference, ExternalReference, and ImageSequenceReference classes
  • Add attributes for:
    • Available Image Bounds
    • Available range
    • Target/Target URL base
    • Selected media reference
    • Metadata

Minor Changes:

  • Vscode is changing the import order of implot
  • Added the vscode config file to the gitignore for anyone else using vscode

Examples:

2024-09-27 11 49 53

2024-09-27 11 49 00

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Sep 27, 2024 •
edited
Loading

CLA Not Signed

jminor
jminor requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

inspector.cpp Outdated Show resolved Hide resolved
inspector.cpp Show resolved Hide resolved
@jminor
Copy link
Member

jminor commented Sep 27, 2024

If you click the "Details" link next to the DCO and EasyCLA checks, there are instructions on how to get those resolved. Let us know if you get stuck or have questions about those.

Jspada200ilm and others added 23 commits October 1, 2024 10:17
@Jspada200ilm
Initial setup of the dropdown menu to select media references
e57d2c7 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Use the key on the media ref object to display in the dropdown
0463c85 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Set the selected media ref index to -1 on clip change, UI updates, Se…
8129364 
…t the active media ref on dropdown change, Display additional attributes

Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Remove test file
5e58a2b 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
remove accidental commit of config file
1f2ce64 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Add vscode folder to git ignore
853d346 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Add method for drawing and modifying the image bounds
1039d5f 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Remove unused import
05ce4e1 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
remove try/catch
ef58ace 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Remove comments
89c3ac7 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Fix bug with the wrong pointer being used
012be20 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Ensure the min value is less then the max
c5865a0 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
Ensure we are checking for the missing reference
002bf81 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
make labels consistent
0a6edf4 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
make text consistent
05d638e 
Signed-off-by: jspadafora <jspadafora@ilm.com>
@Jspada200ilm
PR feedback
c2d4b20 
Signed-off-by: James Spadafora <spadjv@gmail.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@yaash45 @Jspada200ilm
Improve clip and transition color changes on hover and select (OpenTi…
170dac1 
…melineIO#67)

Signed-off-by: Yaash Jain <yaash.jain45@gmail.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@agetroortega @Jspada200ilm
Add drag & drop functionality for opening files (in macOS) (OpenTimel…
b230c2a 
…ineIO#69)

Signed-off-by: Fernando Ortega <agetro06@gmail.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@yaash45 @Jspada200ilm
Add instruction to do a recursive clone before attempting a build (Op…
358ed9f 
…enTimelineIO#66)

* Merge in changes from OpenTimelineIO#55 + Improve build steps formatting

Co-authored-by: David Douglas @ddouglas
Signed-off-by: Yaash Jain <yaash.jain45@gmail.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@austinwitherspoon @Jspada200ilm
Expose methods to load OTIO files in WASM through Javascript (OpenTim…
5ff0f78 
…elineIO#70)

* Add LoadString function
* Add LoadUrl function
* Export LoadUrl and LoadString through emscriptem
* Update html template to add OTIO load helpers
* Document WASM load methods

Signed-off-by: Austin Witherspoon <46503991+austinwitherspoon@users.noreply.github.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@dependabot @Jspada200ilm
Bump libs/glfw from dc557ec to b35641f (OpenTimelineIO#48)
7963d25 
Bumps [libs/glfw](https://github.com/glfw/glfw) from `dc557ec` to `b35641f`.
- [Release notes](https://github.com/glfw/glfw/releases)
- [Commits](glfw/glfw@dc557ec...b35641f)

---
updated-dependencies:
- dependency-name: libs/glfw
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@dependabot @Jspada200ilm
Bump libs/opentimelineio from 4b3b673 to 5184c36 (OpenTimelineIO#71)
2432f70 
Bumps [libs/opentimelineio](https://github.com/AcademySoftwareFoundation/OpenTimelineIO) from `4b3b673` to `5184c36`.
- [Release notes](https://github.com/AcademySoftwareFoundation/OpenTimelineIO/releases)
- [Commits](AcademySoftwareFoundation/OpenTimelineIO@4b3b673...5184c36)

---
updated-dependencies:
- dependency-name: libs/opentimelineio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: jspadafora <jspadafora@ilm.com>
@TrevorAyl @Jspada200ilm
Adjust timecode track height dynamically (OpenTimelineIO#75)
75a333d 
Signed-off-by: TrevorAyl <37515792+TrevorAyl@users.noreply.github.com>
@jspada200 jspada200 force-pushed the Add-Media-Reference-to-inspector branch from bfc40d6 to 75a333d Compare October 1, 2024 17:17
@jspada200
Copy link
Author

If you click the "Details" link next to the DCO and EasyCLA checks, there are instructions on how to get those resolved. Let us know if you get stuck or have questions about those.

Thanks, I was able to figure out the DCO but my manager had me submit my name for the CLA. I am just waiting for them to let me know what needs to be done.

Thanks!

@jminor
Copy link
Member

jminor commented Oct 1, 2024

Ok, great. Let us know if there are questions about the CLA. I know some organizations can take a while to get those signed.

jminor
jminor approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jminor jminor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is approved, just waiting for CLA.

@jspada200
Copy link
Author

Just to follow up on this. Turns our that ILM does not have the CLAs setup for OTIO and needs to go through the process of getting those with Legal so it will be a bit longer this this and other PRs from ILM can be merged. Going to leave this PR open for now and stay on top of things here.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jminor jminor jminor approved these changes

Assignees
No one assigned
Labels
devdays24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jspada200 @jminor @reinecke @Jspada200ilm @yaash45 @agetroortega @austinwitherspoon @TrevorAyl