Introduce new command revoke-issued
#1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There exists in easyrsa command 'revoke', the unfortunate possibility to revoke an incorrect certificate, far too easily. For interactive use, require user to specify 'revoke-issued'. revoke: Replace conflicting file checks with specific command selection Remove the checks for accidental use of 'revoke', when 'revoke-expired' or 'revoke-renewed' is intended. Replace these checks by forcing the user to decide which type of revoke command is required. When batch mode is enabled, assume that 'revoke' is intended. Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
TinCanTech
force-pushed
the
expect-renew-type
branch
from
30adebb to
b558fea
Compare
TinCanTech
changed the title
revoke-issued
Signed-off-by: Richard T Bonhomme <tincantech@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the checks for accidental use of 'revoke', when 'revoke-expired' or 'revoke-renewed' is intended.
Replace these checks by forcing the user to decide which type of revoke command is required.
When batch mode is enabled, assume that 'revoke' is intended.
Edit: LGTM (The branch name is incorrect but I'm lazy) #1265
This is an inter-active usage issue, like an "easy mistake to make", which
easyrsashould try to resolve.