Skip to content

Commit

Permalink
Fixed call of virtual from DTOR issue
Browse files Browse the repository at this point in the history
Removed virtual and changed the only overrider of the virtual to
do the special case

Signed-off-by: Charlie Vigue <charlie.vigue@openvpn.com>
  • Loading branch information
cvigue authored and dsommers committed Nov 29, 2023
1 parent a93d711 commit deaced4
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions openvpn/common/scoped_fd.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,12 @@ class ScopedFD
{
if (::close(fd) == -1)
eno = errno;
post_close(eno);
// OPENVPN_LOG("**** SFD CLOSE fd=" << fd << " errno=" << eno);
fd = -1;
}
return eno;
}

virtual void post_close(const int close_errno)
{
}

virtual ~ScopedFD()
{
// OPENVPN_LOG("**** SFD DESTRUCTOR");
Expand Down

0 comments on commit deaced4

Please sign in to comment.