Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): document Ownable #207

Merged
merged 4 commits into from
Jul 23, 2024
Merged

feat(docs): document Ownable #207

merged 4 commits into from
Jul 23, 2024

Conversation

alexfertel
Copy link
Contributor

@alexfertel alexfertel commented Jul 22, 2024

Resolves #206 & Resolves #12

There are quite a few changes besides what one would expect because I fixed all the broken links in the contract's crate after adding #![deny(rustdoc::broken_intra_doc_links)].

@alexfertel alexfertel added priority: 2 We will resolve this in a short timeframe. type: docs Changes to documentation. effort: medium Default level of effort. labels Jul 22, 2024
@alexfertel alexfertel self-assigned this Jul 22, 2024
Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit 3f605cc
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/669e54ad6a38260008a32c38
😎 Deploy Preview https://deploy-preview-207--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.1%. Comparing base (5eeb152) to head (3f605cc).

Additional details and impacted files
Files Coverage Δ
contracts/src/access/control.rs 90.1% <ø> (ø)
contracts/src/access/ownable.rs 93.0% <ø> (ø)
contracts/src/token/erc20/extensions/burnable.rs 100.0% <ø> (ø)
contracts/src/token/erc721/extensions/burnable.rs 100.0% <100.0%> (ø)
...ontracts/src/token/erc721/extensions/enumerable.rs 88.2% <ø> (ø)
contracts/src/token/erc721/mod.rs 96.2% <ø> (ø)
lib/crypto/src/merkle.rs 97.9% <ø> (ø)
contracts/src/token/erc20/extensions/metadata.rs 0.0% <0.0%> (ø)
contracts/src/token/erc721/extensions/metadata.rs 0.0% <0.0%> (ø)

Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it.

Copy link
Member

@qalisander qalisander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexfertel alexfertel merged commit 4b07d68 into main Jul 23, 2024
21 checks passed
@alexfertel alexfertel deleted the alexfertel/ownable-docs branch July 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Default level of effort. priority: 2 We will resolve this in a short timeframe. type: docs Changes to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ownable documentation [Tracking] Ownable
3 participants