Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: erc165 + structs #304

Merged
merged 8 commits into from
Oct 2, 2024
Merged

docs: erc165 + structs #304

merged 8 commits into from
Oct 2, 2024

Conversation

qalisander
Copy link
Member

Follows #62

PR Checklist

  • Tests
  • Documentation

@netlify Netlify
Copy link

netlify bot commented Oct 2, 2024 •
edited
Loading

✅ Deploy Preview for contracts-stylus ready!

Name Link
🔨 Latest commit e0337f5
🔍 Latest deploy log https://app.netlify.com/sites/contracts-stylus/deploys/66fd7d3e6f08ef0008a2f7f3
😎 Deploy Preview https://deploy-preview-304--contracts-stylus.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qalisander qalisander changed the title docs: erc165 docs: erc165 + structs Oct 2, 2024
@qalisander qalisander marked this pull request as ready for review October 2, 2024 13:54
@qalisander qalisander changed the title docs: erc165 + structs docs: erc165 + structures Oct 2, 2024
@qalisander qalisander changed the title docs: erc165 + structures docs: erc165 + structs Oct 2, 2024
bidzyyys
bidzyyys approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@bidzyyys bidzyyys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

ggonzalez94
ggonzalez94 reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Left some suggestions.
We should be careful with docs version and format and follow the format at #300. The current links on this PR don't work.

docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/utilities.adoc Outdated Show resolved Hide resolved
qalisander and others added 6 commits October 2, 2024 19:21
@qalisander
++
b40a2af
@qalisander @ggonzalez94
Update docs/modules/ROOT/pages/utilities.adoc
3aade16 
Co-authored-by: Gustavo Gonzalez <gustavo.gonzalez@openzeppelin.com>
@qalisander @ggonzalez94
Update docs/modules/ROOT/pages/utilities.adoc
5ac6e9f 
Co-authored-by: Gustavo Gonzalez <gustavo.gonzalez@openzeppelin.com>
@qalisander @ggonzalez94
Update docs/modules/ROOT/pages/utilities.adoc
4a52e38 
Co-authored-by: Gustavo Gonzalez <gustavo.gonzalez@openzeppelin.com>
@qalisander
++
46f73f5
@qalisander
++
113eecd
ggonzalez94
ggonzalez94 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ggonzalez94 ggonzalez94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀 can you check the last nit I reopened on the comments?

@qalisander qalisander merged commit c40dc8e into main Oct 2, 2024
16 checks passed
qalisander added a commit that referenced this pull request Oct 4, 2024
@qalisander
docs: erc165 + structs (#304)
89ee202 
Follows up #62

#### PR Checklist

- [ ] Tests
- [x] Documentation

---------

Co-authored-by: Gustavo Gonzalez <gustavo.gonzalez@openzeppelin.com>
(cherry picked from commit c40dc8e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggonzalez94 ggonzalez94 ggonzalez94 approved these changes

@bidzyyys bidzyyys bidzyyys approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qalisander @ggonzalez94 @bidzyyys