fix(L-01): Incomplete Implementation for checkpoints.rs #323
+160
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qalisander
force-pushed
the
fix/L-01-Incomplete-Implementation-for-checkpoints.rs
branch
from
19d98e6
to
111aa36
Compare
qalisander
commented
Oct 4, 2024
bidzyyys
reviewed
Oct 6, 2024
| use core::ops::{Add, Div, Mul, Sub}; | ||
|
|
||
| use alloy_primitives::Uint; | ||
| use stylus_sdk::prelude::*; |
There was a problem hiding this comment.
Import only what we need.
| impl<const B: usize, const L: usize> Accessor | ||
| for stylus_sdk::storage::StorageUint<B, L> | ||
| { | ||
| type Wraps = Uint<B, L>; |
There was a problem hiding this comment.
Nit: I do not like Wraps, I would remove.
There was a problem hiding this comment.
Or at least make it more self-descripting
There was a problem hiding this comment.
stylus_sdk::StorageType::Wraps has the same name for associated abi type. What other ideas you have?
| } | ||
|
|
||
| /// Abstracts number inside the checkpoint contract. | ||
| pub trait Num: Add + Sub + Mul + Div + Ord + Sized + Copy { |
There was a problem hiding this comment.
I think the name should be more self-descripting.
There was a problem hiding this comment.
Not ideal, but what you think is better? AbiNum?
There was a problem hiding this comment.
I would add macros for Size generation similar to these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends checkpoints implementation without code duplications, albeit it has a bit complex generics