Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI. #4

Merged
merged 5 commits into from
Jul 19, 2024
Merged

Fix CI. #4

merged 5 commits into from
Jul 19, 2024

Conversation

clement-ux
Copy link
Contributor

@clement-ux clement-ux commented Jul 18, 2024 •
edited
Loading

On the CI, the name of the "main" branch is master but is main on the repo, that's why CI is not running when merging PR.

And fix a bit the tests.

shahthepro
shahthepro approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@shahthepro shahthepro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this

@naddison36 naddison36 merged commit 4397dbf into main Jul 19, 2024
1 of 2 checks passed
@clement-ux clement-ux deleted the clement/fix-CI branch July 19, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naddison36 naddison36 naddison36 approved these changes

@shahthepro shahthepro shahthepro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clement-ux @naddison36 @shahthepro