Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-03 Use calldata instead of memory for external function parameters #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

N-03 Use calldata instead of memory for external function parameters #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/contracts/LidoARM.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ contract LidoARM is Initializable, AbstractARM {
* Reference: https://docs.lido.fi/contracts/withdrawal-queue-erc721/
* Note: There is a 1k amount limit. Caller should split large withdrawals in chunks of less or equal to 1k each.)
*/
function requestLidoWithdrawals(uint256[] memory amounts)
function requestLidoWithdrawals(uint256[] calldata amounts)
external
onlyOperatorOrOwner
returns (uint256[] memory requestIds)
Expand All @@ -93,7 +93,7 @@ contract LidoARM is Initializable, AbstractARM {
* @notice Claim the ETH owed from the redemption requests and convert it to WETH.
* Before calling this method, caller should check on the request NFTs to ensure the withdrawal was processed.
*/
function claimLidoWithdrawals(uint256[] memory requestIds) external {
function claimLidoWithdrawals(uint256[] calldata requestIds) external {
uint256 etherBefore = address(this).balance;

// Claim the NFTs for ETH.
Expand Down