Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bootstrap #1

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Feat/bootstrap #1

merged 2 commits into from
Jul 24, 2023

Conversation

dcodes05
Copy link
Contributor

@dcodes05 dcodes05 commented Jul 12, 2023

Bootstrap the new DEFI frontend monorepo.

Structure is the following:

  • apps --> main applications/modules -> should mostly be skeletons as the logic should be put in libs folder
  • libs --> put shared things like MUI theme, query client configuration and the every app should have its own lib to host the business logic and UI rendering

Items covered:

  • - bootstrap NX with Vite
  • - support eslint and prettier
  • - support routing (comes with react-router by default)
  • - shared MUI theme
  • - shared query client
  • - individual storybook -> all stories are collected in a global storybook that aggregates everything from the libs folder
  • - dummy stories for evert lib
  • - basic translation mechanism -> would require some refinement
  • - translation scripts
  • - devcontainer/codespaces support
  • - deployable storybook
  • - github actions setup

@dcodes05 dcodes05 requested a review from smitch88 July 12, 2023 21:21
@dcodes05 dcodes05 force-pushed the feat/bootstrap branch 2 times, most recently from 1666945 to 65b769c Compare July 13, 2023 12:38
@dcodes05 dcodes05 temporarily deployed to github-pages July 13, 2023 12:49 — with GitHub Pages Inactive
@dcodes05 dcodes05 force-pushed the feat/bootstrap branch 3 times, most recently from 448e7e3 to 80afc8a Compare July 13, 2023 13:08
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is strict-peer-dependencies the same as legacy-peer-deps or is that something different? I'd like to try keep the correct peer deps if we can without bypassing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's pretty much it. It is part of the boilerplate generated by NX. I can remove it, at least for now it shouldn't break anything

Copy link
Contributor

@smitch88 smitch88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Good first step

@dcodes05 dcodes05 merged commit 7e2d18d into main Jul 24, 2023
1 check passed
@dcodes05 dcodes05 deleted the feat/bootstrap branch July 24, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants