Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAS-177] Local icons, meta tags and Scott's PR feedback #19

Merged
merged 4 commits into from
Aug 28, 2023
Merged

[TAS-177] Local icons, meta tags and Scott's PR feedback #19

merged 4 commits into from
Aug 28, 2023

Conversation

dcodes05
Copy link
Contributor

@dcodes05 dcodes05 commented Aug 25, 2023 •
edited by rafaelugolini
Loading

  • extracted the History table core to a shared component
  • added meta tags to oeth app index.html file
  • added all the icons from the nextjs repo and changed the components to use relative paths instead of absolute paths

https://www.notion.so/originprotocol/00c83143d51849a19a6c99ca369a0ce6?v=2d767630307148d6a804c27bae47f019&p=ae7c3d09c31447a5885d738a40e98e2e&pm=s

@github-actions
Copy link

github-actions bot commented Aug 25, 2023 •
edited
Loading

Messages
📖 ✅ task id: TAS-177

Generated by 🚫 dangerJS against 53f0029

@github-actions github-actions bot changed the title Local icons, meta tags and Scott's PR feedback [TAS-177] Local icons, meta tags and Scott's PR feedback Aug 25, 2023
@notion-workspace
Copy link

[TAS-177] Local icons, meta tags and Scott's PR feedback

smitch88
smitch88 reviewed Aug 25, 2023
View reviewed changes
libs/shared/components/src/DataTable/DataTable.tsx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

smitch88
smitch88 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@smitch88 smitch88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smitch88 smitch88 merged commit 9d4fc77 into main Aug 28, 2023
3 of 4 checks passed
@smitch88 smitch88 deleted the feat/icons branch August 28, 2023 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitch88 smitch88 smitch88 approved these changes

@rafaelugolini rafaelugolini Awaiting requested review from rafaelugolini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcodes05 @smitch88