-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TAS-167] Feat/swap #8
Conversation
style: hover behaviour for swap item wip
@@ -18,5 +18,5 @@ | |||
"src/**/*.spec.jsx", | |||
"src/**/*.test.jsx" | |||
], | |||
"include": ["src/**/*.js", "src/**/*.jsx", "src/**/*.ts", "src/**/*.tsx"] | |||
"include": ["src/**/*.js", "src/**/*.jsx", "src/**/*.ts", "src/**/*.tsx", "../../libs/defi/oeth/src/components/TopNav.tsx"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this ../../libs/defi/oeth/src/components/TopNav.tsx
necessary?
export function HistoryTable({ rows, filter }: Props) { | ||
const intl = useIntl(); | ||
const [columnFilters, setColumnFilters] = useState<ColumnFiltersState>([]); | ||
const columns = useMemo( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May consider moving this as a prop passed for more generic "Table" component that wraps MUI and added to shared
components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Met on call to discuss files, structure, patterns related to MUI, and various other things.
Approving to get baseline so chromatic diffs work better for future changes and exchanges w/ design.
https://www.notion.so/originprotocol/00c83143d51849a19a6c99ca369a0ce6?v=2d767630307148d6a804c27bae47f019&p=ae7c3d09c31447a5885d738a40e98e2e&pm=s