Native staking updates #2023
Merged
Native staking updates #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed spelling of ValidatorAccountant events Implemented depositSSV
Moved MAX_STAKE on ValidatorAccountant to a constant
naddison36
requested review from
sparrowDom,
DanielVF and
shahthepro
as code owners
sparrowDom
reviewed
Apr 22, 2024
| @@ -85,16 +84,29 @@ abstract contract ValidatorAccountant is ValidatorRegistrator { | |||
|
|
|||
| /// @dev Throws if called by any account other than the Strategist | |||
| modifier onlyStrategist() { | |||
| require(msg.sender == strategist, "Caller is not the Strategist"); | |||
| require( | |||
| msg.sender == IVault(VAULT_ADDRESS).strategistAddr(), | |||
sparrowDom
reviewed
Apr 22, 2024
| @@ -157,7 +169,7 @@ abstract contract ValidatorAccountant is ValidatorRegistrator { | |||
| IWETH9(WETH_TOKEN_ADDRESS).deposit{ value: wethToVault }(); | |||
| IWETH9(WETH_TOKEN_ADDRESS).transfer(VAULT_ADDRESS, wethToVault); | |||
|
|
|||
| emit AccuntingFullyWithdrawnValidator( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strategistfrom strategy as its already in the Vault