Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy 093 - Remove frxETH Strategies #2040

Merged
merged 2 commits into from
May 1, 2024

Conversation

shahthepro
Copy link
Collaborator

@shahthepro shahthepro commented Apr 30, 2024

To do (Before execution):

  • Have the strategist donate a small amount of frxETH to the Vault and call depositToStrategy. Otherwise, the proposal execution will fail (since the current frxETH strategy implementation doesn't have a zero check). Done, thanks to @sparrowDom

If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

@DanielVF
Copy link
Collaborator

image

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that:

  • the proposal actions match the deploy script
  • the actions are correct and have the correct addresses

Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the governance proposal matches the 093 script

@shahthepro shahthepro merged commit 33de720 into master May 1, 2024
13 of 14 checks passed
@shahthepro shahthepro deleted the shah/remove-frxeth-strategies branch May 1, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants