Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aero harvester contract #2045

Merged
merged 5 commits into from
May 13, 2024

Conversation

PraneshASP
Copy link
Contributor

@PraneshASP PraneshASP commented May 3, 2024

Description:

Added a new contract AeroHarvester to harvest AERO token rewards from the Aerodrome AMM, swap it back to Wrapped Ether and send it to the vault contract. This is required for the Aerodrome AMO strategy.


If you made a contract change, make sure to complete the checklist below before merging it in master.

Refer to our documentation for more details about contract security best practices.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Copy link

github-actions bot commented May 3, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against f885605

@PraneshASP PraneshASP changed the title [WIP] Aero harvester Aero harvester contract May 6, 2024
@PraneshASP PraneshASP marked this pull request as ready for review May 6, 2024 16:53
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shares a lot of code with the BaseHarvester. Can it be refactored so it only re-implements the things that are different?

@PraneshASP
Copy link
Contributor Author

This shares a lot of code with the BaseHarvester. Can it be refactored so it only re-implements the things that are different?

I tried the same earlier, but the Base harvester seems to be more Ethereum focused as there are lot of internal functions to handle swaps with various platforms. if we want to refactor, there'll be a lot of breaking changes in the BaseHarvester contract. To keep things simple, I created a new harvester contract specific to Aero (base).

cc: @sparrowDom

@PraneshASP PraneshASP self-assigned this May 8, 2024
@DanielVF DanielVF added the contracts Works related to contracts label May 8, 2024
@PraneshASP PraneshASP merged commit 4167225 into PraneshASP/aero-pricefeed May 13, 2024
8 of 16 checks passed
@PraneshASP PraneshASP deleted the PraneshASP/aero-harvester branch May 13, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contracts Works related to contracts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants