-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Inverted Quoter for AMO fork test. #2210
Merged
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
d29dc6f
feat: add inverted quoter for rebalancing.
clement-ux 4e9d161
test: use quoter for AMO rebalancing.
clement-ux 8810a77
chore: increase gas limit for test for AMO quoter.
clement-ux 5e7df11
fix: remove arguments from quoter call.
clement-ux 9b91a6a
fix: set strategist back to origin strategist for quoter.
clement-ux 585b40a
feat: add AMO quoter for `amountToSwapToReachPrice`.
clement-ux 4390da3
feat: add quoter for moving price in AMO tests and upgrade swap funct…
clement-ux aea2198
docs: add descriptions to functions.
clement-ux bf51ef9
feat: add `overrideWethShare` on `quoteAmountToSwapBeforeRebalance`.
clement-ux c502ed6
fix: use dictionnary syntax to call function that has same name as an…
clement-ux 7383e79
fix: increase max iteration for quoter.
clement-ux ffa2d8e
fix: failling test.
clement-ux 280f6b4
fix: move AMOQuoter to fixture.
clement-ux 8abb412
feat: add more comments.
clement-ux 3e076b9
fix: rethink variance calculation for AMO Quoter.
clement-ux a4d585b
fix: give more WETH at start and simplifies swap.
clement-ux ef2bf26
fix: remove unused import.
clement-ux 2d663be
fix: _minTokenReceived is 99% of amountToSwap.
clement-ux 80d115b
fix: refactor % comparison.
clement-ux 6b72dc9
fix: change public into internal.
clement-ux 944bb28
fix: adjust quoteAmountToSwapBeforeRebalance for custom shares.
clement-ux 26035cc
fix: split boundaries for quoter.
clement-ux ea44472
fix: fetch governor before impersonning.
clement-ux d6d386a
fix: increase tolereance eth remaining in AMO after withdraw.
clement-ux aa3bb5b
fix: fix failing test and add description.
clement-ux 29c18b5
fix: add doc for edge case in withdraw.
clement-ux f1c84b0
Merge branch 'master' into clement/add-quoter-for-AMO-fork-tests
clement-ux 10e1ba8
fix: adjust test with latest values.
clement-ux 920099b
Merge remote-tracking branch 'origin/master' into clement/add-quoter-…
sparrowDom 8dce05e
Fix issues with fork testing (#2255)
sparrowDom d146df8
Merge remote-tracking branch 'origin/master' into clement/add-quoter-…
sparrowDom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool that makes sense.
nit: Maybe a slightly more "natural" way to express it would be:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree, I was to avoid rounding issue. But I've no problem to change it.