Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OETHb] Timelock delay update #2265

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Conversation

shahthepro
Copy link
Collaborator

Deployment

  • No deployed contracts

Governance

Generated JSON files for schedule and execute are:

Deploy checklist

Two reviewers complete the following checklist:

- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

Copy link

github-actions bot commented Oct 2, 2024

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against a9ba43a

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.50%. Comparing base (44559cf) to head (a9ba43a).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2265    +/-   ##
========================================
  Coverage   53.50%   53.50%            
========================================
  Files          79       79            
  Lines        4071     4071            
  Branches      816     1070   +254     
========================================
  Hits         2178     2178            
  Misses       1890     1890            
  Partials        3        3            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sparrowDom
sparrowDom previously approved these changes Oct 2, 2024
Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clement-ux
clement-ux previously approved these changes Oct 2, 2024
Copy link
Contributor

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shahthepro shahthepro dismissed stale reviews from clement-ux and sparrowDom via a9ba43a October 2, 2024 10:02
@shahthepro shahthepro merged commit 927fe2d into master Oct 2, 2024
15 of 18 checks passed
@shahthepro shahthepro deleted the shah/oethb-timelock-delay-update branch October 2, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants