Harvest Action now collects if there is more than 0.5 execution rewards #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naddison36
requested review from
sparrowDom,
DanielVF,
shahthepro and
clement-ux
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2281 +/- ##
==========================================
- Coverage 53.26% 52.13% -1.13%
==========================================
Files 79 79
Lines 4089 4089
Branches 820 1074 +254
==========================================
- Hits 2178 2132 -46
- Misses 1908 1954 +46
Partials 3 3 ☔ View full report in Codecov by Sentry. |
shahthepro
approved these changes
Oct 20, 2024
Comment on lines
+70
to
+71
| consensusRewards.gt(parseEther("1")) || | ||
| executionRewards.gt(parseEther("0.5")) |
There was a problem hiding this comment.
nit: Could probably use gte but not a big deal
There was a problem hiding this comment.
yeah, the line has to be drawn somewhere. Those amounts were arbitrary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes