Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add comment #2288

Merged
merged 2 commits into from
Oct 24, 2024
Merged

add comment #2288

merged 2 commits into from
Oct 24, 2024

Conversation

sparrowDom
Copy link
Member

add comment

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@sparrowDom
Copy link
Member Author

merging this in since it is only a comment

@sparrowDom sparrowDom merged commit 5f54f83 into nicka/ousd-gas Oct 24, 2024
11 of 14 checks passed
@sparrowDom sparrowDom deleted the sparrowDom/addComments branch October 24, 2024 10:27
Copy link

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against ae3764a

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.12%. Comparing base (bc710f3) to head (ae3764a).
Report is 1 commits behind head on nicka/ousd-gas.

Additional details and impacted files
@@                Coverage Diff                 @@
##           nicka/ousd-gas    #2288      +/-   ##
==================================================
- Coverage           53.36%   53.12%   -0.25%     
==================================================
  Files                  79       79              
  Lines                4098     4098              
  Branches              820      820              
==================================================
- Hits                 2187     2177      -10     
- Misses               1908     1918      +10     
  Partials                3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants