Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

txHelper error handling additions #4199

Merged
merged 8 commits into from
Jan 7, 2020
Merged

txHelper error handling additions #4199

merged 8 commits into from
Jan 7, 2020

Conversation

mikeshultz
Copy link
Contributor

Description:

Error handling to deal with bad txHash error (Probably web3.js internal)

Ref: #4197

Checklist:

@mikeshultz mikeshultz added bug Something isn't working as intended graphql labels Jan 6, 2020
@mikeshultz mikeshultz self-assigned this Jan 6, 2020
@mikeshultz mikeshultz marked this pull request as ready for review January 6, 2020 22:40
@mikeshultz mikeshultz requested review from franckc and nick January 6, 2020 22:40
franckc
franckc approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@franckc franckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit otherwise LGTM

Thanks for hardening this code!

packages/graphql/src/mutations/_txHelper.js Outdated Show resolved Hide resolved
@mikeshultz mikeshultz merged commit 38b166c into master Jan 7, 2020
@mikeshultz mikeshultz deleted the mikeshultz/invalid-params-handling branch January 7, 2020 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@franckc franckc franckc approved these changes

@nick nick Awaiting requested review from nick

Assignees

@mikeshultz mikeshultz

Labels
bug Something isn't working as intended graphql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeshultz @franckc