Feat/refactor frontend components #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Prisma link / walkthrough.
Refactor and reduce to simple mapping.
Fix Icon src + altDescription
tomhirst
reviewed
Aug 22, 2022
| @@ -22,57 +22,52 @@ const AccountBalances: FunctionComponent<AccountBalancesProps> = () => { | |||
| return total.add(lockup.amount); | |||
| }, ethers.BigNumber.from("0")); | |||
|
|
|||
| const cardContentData = [ | |||
tomhirst
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks for the contribution @crypblizz8!
This is a good start to the larger task mentioned in my issue and your PR:
- The refactoring in
AccountBalances.tsxis smart. There are probably more places we can do this in now we're out of the scrappy "get this live" phase of the dApp. - Organising components into category folders helps. Let's just be careful not to bury important top-level and/or generic code so deep that it becomes unavailable at a glance.
I've tested this as working so I'm happy to approve, though I feel there's more work to do be done before we can close #291, for instance:
- Checking for duplicate code across components
- Consolidating multi-use patterns
- Further render markup reduction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #291, explored the frontEnd Code and see where parts could be improved in cleanliness / structure.
Overview
AccountBalances.tsxto avoid repetition in code.Going Forward
This is only a small part of a bigger project but a starting point for refactoring/cleaning up parts of the front-end source code. Other parts include looking through more of the components and refactoring where code is duplicated as per the
AccountBalances.tsxexample.Created Folders
Utils
Icons
Other folder suggestions for future/remaining:
Navigation
Stats
Step
Slide
Utils
Buttons
Card
Icon