-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Token Merger Deploy Script #418
Conversation
* Add Migrator contract * Fix some tests * Code review changes * Update OgvStaking tests * Disable delegation tests * Allow just unstakes * Fix comment * More cleanup * Fix brownie tests
* Check available balance in `previewRewards` * Chore: forge fmt --------- Co-authored-by: Daniel Von Fange <daniel@leancoder.com>
Starting test:
|
Long term goal is to have the base script expose a registry for deployed contracts. This way when you make a fork test, you run the script, then use the registry to get to the latest deployed contract addresses. Also, the idea would be to return a governance object that knows how to both execute its commands in a fork test, but also return something useful for submitting to governance. We'll have to support both governance proposals AND multisig to direct to timelock for these migrations. Probably our highest priority though is getting some good fork tests to run after these deploys run. |
return; | ||
} | ||
|
||
isForked = vm.envOr("IS_FORK", false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vm.isContext(VmSafe.ForgeContext.ScriptDryRun)
might be a much cleaner way than environment variables for this one. Will make this change
No description provided.