Add transaction receipts to responses #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mihajlo-Pavlovic
approved these changes
Sep 10, 2024
u-hubar
requested changes
Sep 10, 2024
managers/asset-operations-manager.js
Outdated
| transactionHash: receipt.transactionHash, | ||
| status: receipt.status, | ||
| }; | ||
| return receipt; |
There was a problem hiding this comment.
We shouldn't change the way returned object looks like, it would be a breaking change otherwise. I suggest we just add additional field operation
managers/asset-operations-manager.js
Outdated
| transactionHash: receipt.transactionHash, | ||
| status: receipt.status, | ||
| }; | ||
| return receipt; |
There was a problem hiding this comment.
Suggested change
| return receipt; | |
| return { | |
| operation: receipt, | |
| transactionHash: receipt.transactionHash, | |
| status: receipt.status, | |
| }; |
| @@ -285,7 +285,7 @@ class BlockchainServiceBase { | |||
| data: { tokenId }, | |||
| }); | |||
|
|
|||
| return tokenId; | |||
| return [tokenId, receipt]; | |||
There was a problem hiding this comment.
Let's return an object to avoid mistakes in the future
Suggested change
| return [tokenId, receipt]; | |
| return { tokenId, receipt }; |
managers/asset-operations-manager.js
Outdated
| tokenId = await this.blockchainService.createAsset( | ||
| let receipt; | ||
| if (paranetUAL == null) { | ||
| [tokenId, receipt] = await this.blockchainService.createAsset( |
There was a problem hiding this comment.
I would suggest returning object here, then destructuring would look like that:
Suggested change
| [tokenId, receipt] = await this.blockchainService.createAsset( | |
| ({ tokenId, receipt } = await this.blockchainService.createAsset( |
managers/asset-operations-manager.js
Outdated
| @@ -352,7 +344,7 @@ class AssetOperationsManager { | |||
| ); | |||
managers/asset-operations-manager.js
Outdated
| ); | ||
| return { | ||
| UAL, | ||
| publicAssertionId, | ||
| operation: getOperationStatusObject(operationResult, operationId), | ||
| operation: { | ||
| updateKnowledgeAssetReceipt: receipt, |
There was a problem hiding this comment.
Suggested change
| updateKnowledgeAssetReceipt: receipt, | |
| updateKnowledgeAsset: receipt, |
managers/asset-operations-manager.js
Outdated
| operation: getOperationStatusObject(operationResult, operationId), | ||
| operation: { | ||
| updateKnowledgeAssetReceipt: receipt, | ||
| localStore: getOperationStatusObject(localStoreOperationResult, UpdateOperationId), |
There was a problem hiding this comment.
Suggested change
| localStore: getOperationStatusObject(localStoreOperationResult, UpdateOperationId), | |
| localStore: getOperationStatusObject(localStoreOperationResult, updateOperationId), |
managers/asset-operations-manager.js
Outdated
| status: getOperationStatusObject({ status: 'COMPLETED' }, null), | ||
| cancelKnowledgeAssetUpdateReceipt: receipt, | ||
| }, | ||
| cancelAssetUpdateReceipt: receipt, |
There was a problem hiding this comment.
We already have it inside operation
Suggested change
| cancelAssetUpdateReceipt: receipt, |
managers/asset-operations-manager.js
Outdated
|
|
||
| return { | ||
| UAL, | ||
| operation: getOperationStatusObject({ status: 'COMPLETED' }, null), | ||
| operation: { | ||
| status: getOperationStatusObject({ status: 'COMPLETED' }, null), |
There was a problem hiding this comment.
This on is not needed, since we only have 1 operation in this function, I would just return operation: receipt
| @@ -53,6 +53,7 @@ class ParanetOperationsManager { | |||
|
|
|||
| return { | |||
| paranetUAL: UAL, | |||
| createParanetReceipt: receipt | |||
There was a problem hiding this comment.
Suggested change
| createParanetReceipt: receipt | |
| operation: receipt |
…ransaction-receipts-to-responses
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was able to test the following methods:
Could not test these methods: