add timed delays for attribute resolution #6
+8
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroxbt
reviewed
Apr 27, 2022
| new Date(new Date().getTime() + 1000); | ||
| response = request('GET', `${this.nodeBaseUrl}/resolve/result/${handler}`); | ||
| body = JSON.parse(response.getBody()); | ||
| if((new Date().getTime()) > milestonesDate + 1000){ |
There was a problem hiding this comment.
Shouldn't we use a sleep (setTimeout) here ? Otherwise the while loop will keep running and it might be cpu intensive
There was a problem hiding this comment.
I think, there is an issue with this Proxy class not having any async or await or promises in it. introducing the sleep using setTimeout will need the use of promises and will affect the usage of the sdk. I think this is the reason why we are using the sync-request library to make requests in the first place.
So my solution here seemed the best solution to delay requests, but i agree there is an infinite loop there.
we need to ask @kotlarmilos form more info about the proxy and whether we rewrite it to use promises instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix the thousand request for resolve/result that freezes webpages