Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending multiple triple store and blockchain implementation info to telemetry #2425

Open
wants to merge 5 commits into
base: v6/develop
Choose a base branch
from

Conversation

brkagithub
Copy link
Contributor

@brkagithub brkagithub commented Apr 12, 2023

Description

Update ot-node to send array of triple store and blockchain implementations instead of default implementation.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran ot-node locally with 3 nodes, setup the telemetry url to be a Webhook.site POST url that i generated and checked whether the nodes sent data in the wanted format to that link. Test was done with Blazegraph and GraphDB combined - 2 repos each (public-current, public-history, private-current, private-history).

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@NZT48 NZT48 added the bug Something isn't working label Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants