error handling for read ETIMEDOUT error #2846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milosstanisavljevic
requested review from
branarakic,
djordjekovac,
NZT48,
zeroxbt and
u-hubar
as code owners
djordjekovac
suggested changes
Dec 25, 2023
zeroxbt
reviewed
Dec 26, 2023
zeroxbt
reviewed
Dec 26, 2023
zeroxbt
reviewed
Dec 26, 2023
zeroxbt
reviewed
Dec 28, 2023
djordjekovac
suggested changes
Jan 5, 2024
added 5 commits
January 12, 2024 12:39
src/controllers/http-api/v0/local-store-http-api-controller-v0.js
Outdated
Show resolved
Hide resolved
djordjekovac
approved these changes
Jan 17, 2024
NZT48
requested changes
Jan 17, 2024
| { errorMessage: 'Unable to handle request' }, | ||
| ); | ||
| this.logger.error( | ||
| `Error handling message from ${peerIdString} to ${this.config.id}: protocol :${protocol} with operationId${message.header.operationId} and keyword:${message.header.keywordUuid}, Error : ${error} `, |
There was a problem hiding this comment.
Please update log messages to be consistent everywhere in PR, they should have following format word: ${value}, so some word, semi-colons followed by space and after that a value
NZT48
approved these changes
Jan 19, 2024
Mihajlo-Pavlovic
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added addition error handling that would potentially solve read ETIMEDOUT error
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: