fix: network message timeout #3106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge v6/develop
zeroxbt
requested review from
branarakic,
djordjekovac,
NZT48 and
u-hubar
as code owners
djordjekovac
approved these changes
Mar 25, 2024
|
Looks good, tested in local and it's working |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently node only aborts message if reading from the stream takes longer than the specified timeout.
This PR ensure that the timeout is measured from the start of the operation, which includes dialing the peer (stream creation) and writing to the stream aswell.
The timeout abort controller dependency is removed as it is not necessary since node v16.