configuration files templates updated #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NZT48
reviewed
Aug 28, 2024
| @@ -57,7 +76,7 @@ | |||
| }, | |||
| "publicCurrent":{ | |||
| "url":"http://localhost:9999", | |||
| "name":"public-current", | |||
| "name":"kb", | |||
There was a problem hiding this comment.
@Mihajlo-Pavlovic double check this change
There was a problem hiding this comment.
@Niks988 we moved to using public-current here it should stay that way
| @@ -57,7 +76,7 @@ | |||
| }, | |||
| "publicCurrent":{ | |||
| "url":"http://localhost:9999", | |||
| "name":"public-current", | |||
| "name":"kb", | |||
There was a problem hiding this comment.
@Niks988 this shouldn't be changed also
| @@ -5,34 +5,53 @@ | |||
| "otp:2043":{ | |||
| "enabled":true, | |||
There was a problem hiding this comment.
Not sure if this should also be parametrised, if someone doesn't want to run node on some network
|
There also should be configuraton for libp2p |
Mihajlo-Pavlovic
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgraded .origintrail_noderc template files (mainnet and testnet)
Fixes # (issue)
None
Type of change
Improvement