V8/new telemetry (Influx implementation) #3424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swamala
requested review from
branarakic,
u-hubar and
Mihajlo-Pavlovic
as code owners
| } | ||
|
|
||
| // Call `setEnvParameters` to load the environment variables | ||
| setEnvParameters(); |
There was a problem hiding this comment.
Look how it's done in sequelize-repository.js line 58
|
|
||
| // Check if required variables are present | ||
| if (!influxDBUrl || !influxDBToken || !influxDBOrg || !influxDBBucket) { | ||
| console.error('One or more required environment variables are missing:'); |
There was a problem hiding this comment.
Don't use console but logger
| @@ -217,15 +218,15 @@ class RepositoryModuleManager extends BaseModuleManager { | |||
| value2 = null, | |||
| value3 = null, | |||
| ) { | |||
| return this.getRepository('event').createEventRecord( | |||
| return influx.sendEventTelemetry( | |||
There was a problem hiding this comment.
This shouldn't be done like this, I think that this function createEventRecord should be moved to the telemetry module and then called from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is about new influx db telemetry event store implementation.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: