[V8, FEATURE] TripleStoreModule and TripleStoreService for new V8 Graph Structure #3427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
u-hubar
added
feature
u-hubar
requested review from
branarakic and
Mihajlo-Pavlovic
as code owners
brkagithub
reviewed
Nov 26, 2024
brkagithub
reviewed
Nov 26, 2024
brkagithub
reviewed
Nov 26, 2024
| keyword, | ||
| knowledgeCollectionUAL, | ||
| knowledgeAssetsUALs, | ||
| triples, |
There was a problem hiding this comment.
should this be called triples? on the client we allow user to create by passing triples/quads so maybe calling it quads is better also to be consistent. or should we allow triples only on the client side?
There was a problem hiding this comment.
This should be statements perhaps, doesn't matter which format it is
brkagithub
reviewed
Nov 26, 2024
src/service/triple-store-service.js
Outdated
| this.repositoryImplementations[repository], | ||
| repository, | ||
| this.ualService.deriveUAL(blockchain, contract, tokenId), | ||
| await this.tripleStoreModuleManager.insertKnowledgeCollectionIntoUnifiedGraph( |
There was a problem hiding this comment.
we can paralelize these two calls with promise.all, right? delete from old graph and move to new, also maybe could add retries here too and do a rollback if it's failing?
u-hubar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.