replaced "~~" with Math.floor()

Osterie · Jan 23, 2023 · 46aeb1a · 46aeb1a
1 parent 2cf434f
commit 46aeb1a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 21 deletions.
diff --git a/color_function/library/classdefinitions.js b/color_function/library/classdefinitions.js
@@ -1,8 +1,3 @@
-//IMPROVEMENT AREAS
-
-//5 It might be more efficient to use a single method to handle the hue, saturation, and lightness calculations, instead of having separate methods for each in the Square class.
-
-
 class Square {
   constructor(ctx, xpos, ypos, hue, saturation, lightness, square_size) {
     this.xpos = xpos;

diff --git a/color_function/script.js b/color_function/script.js
@@ -2,13 +2,13 @@
 
 const c =  console.log.bind(console);
 
-const get_hue_expression = document.getElementById("hue_expression");
-const get_saturation_expression = document.getElementById("saturation_expression");
-const get_lightness_expression = document.getElementById("lightness_expression");
-const get_size_lower = document.getElementById("size_lower");
-const get_size_upper = document.getElementById("size_upper");
-const get_pixel_ratio = document.getElementById("pixel_ratio");
-const get_upscale_button = document.getElementById("upscale");
+const get_hue_expression = document.querySelector("#hue_expression");
+const get_saturation_expression = document.querySelector("#saturation_expression");
+const get_lightness_expression = document.querySelector("#lightness_expression");
+const get_size_lower = document.querySelector("#size_lower");
+const get_size_upper = document.querySelector("#size_upper");
+const get_pixel_ratio = document.querySelector("#pixel_ratio");
+const get_upscale_button = document.querySelector("#upscale");
 
 get_hue_expression.addEventListener("change", function () {
   hue_expression = get_hue_expression.value;
@@ -33,8 +33,8 @@ get_lightness_expression.addEventListener("change", function () {
 
 get_pixel_ratio.addEventListener("change", function () {
   pixel_ratio = +get_pixel_ratio.value;
-  size_upper = ~~(+get_size_upper.value / pixel_ratio);
-  size_lower = ~~(+get_size_lower.value / pixel_ratio);
+  size_upper = Math.floor(+get_size_upper.value / pixel_ratio);
+  size_lower = Math.floor(+get_size_lower.value / pixel_ratio);
   distance_left_x_zooming = size_lower
   distance_top_y_zooming = size_lower
   matrix_squares.create_squares(size_lower, size_lower, size_upper, size_upper, pixel_ratio)
@@ -43,9 +43,7 @@ get_pixel_ratio.addEventListener("change", function () {
 
 get_size_lower.addEventListener("change", function () {
   let old_size = size_lower
-  size_lower = ~~(+get_size_lower.value / pixel_ratio);
-
-
+  size_lower = Math.floor(+get_size_lower.value / pixel_ratio);
   const absolute_width = canvas.width / (size_upper - size_lower + index_zero);
   var distance_from_top_left = (absolute_width) * (old_size - size_lower)
   var image_size = ((absolute_width) * (size_upper - old_size + index_zero ))
@@ -59,14 +57,12 @@ get_size_lower.addEventListener("change", function () {
 
 get_size_upper.addEventListener("change", function () {
   let old_size = size_upper
-  size_upper = ~~(+get_size_upper.value / pixel_ratio);
+  size_upper = Math.floor(+get_size_upper.value / pixel_ratio);
 
   const absolute_width = canvas.width / (size_upper - size_lower + index_zero);
   var image_size = ((absolute_width) * (old_size - size_lower + index_zero))
   ctx.drawImage(resizing_img, 0, 0, image_size, image_size);
 
-
-
   matrix_squares.change_size(size_lower, size_upper, old_size, 'higher');
   update_images(canvas)
 });
@@ -78,7 +74,7 @@ get_upscale_button.addEventListener("click", function () {
 
 //-----------------------Canvas-----------------------------
 
-let canvas = document.getElementById("canvas");
+let canvas = document.querySelector("#canvas");
 const ctx = canvas.getContext("2d", { alpha: false });
 
 //Check class for these settings!