This repository has been archived by the owner on Jun 24, 2022. It is now read-only.
Added support for enabling SSL redirect when using an ALB ingress controller #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't bumped the chart version since I guess it's not up to me to decide on which version this is going to be merged but I can obviously amend this commit if you want me to |
jordiprats
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
To be able to enable the SSL redirect when using an ALB controller you must have a path definition for the redirect as stated here
Given than the paths are statically defined on the ingress template (and I guess there's not much use case for having it otherwise) I have added a flag for injecting the needed code to make this helm chart compatible with the ALB SSL redirection
kind regards,