Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(null): adding operators ISNULL and NOTNULL #32

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

Yves-MENGELLE-OF
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (53e6f43) to head (d9cf24c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #32      +/-   ##
============================================
+ Coverage     98.13%   98.14%   +0.01%     
- Complexity      256      260       +4     
============================================
  Files            50       51       +1     
  Lines           482      485       +3     
  Branches         22       22              
============================================
+ Hits            473      476       +3     
  Misses            1        1              
  Partials          8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arnaud-thorel-of arnaud-thorel-of left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your PR,

You just have to :

  • correct javadoc on operations
  • add a little assertion on the visitor result

@Yves-MENGELLE-OF Yves-MENGELLE-OF force-pushed the feature/dealingWithNull branch 2 times, most recently from 0473dd1 to b253ce1 Compare March 21, 2024 15:29
@Yves-MENGELLE-OF Yves-MENGELLE-OF force-pushed the feature/dealingWithNull branch from b253ce1 to d754705 Compare March 21, 2024 15:58
@arnaud-thorel-of arnaud-thorel-of merged commit 86140ea into main Mar 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants