-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest pytest
and xdoctest
#1632
Conversation
The conda package is not yet available. Will re-run CI in a bit. |
Looks like my namespace hack isn't working. I'll need to return to this next week. |
The latest pytest (v8.0.0) seems to have broken the conventional approach for injecting commands into the doctest namespace (used in the doctests). Waiting to see what happens in pytest-dev/pytest#11929 Update: Fix was merged to the main development branch. Should be fixed in |
This functionality has been borked with 8.0.0 (See: pytest-dev/pytest#11873). No way of upgrading until a fix arrives. |
The issue persists: pytest-dev/pytest#11884 |
Note It appears that this Pull Request modifies the On inspection, the No further action is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Pull Request Checklist:
number
) and pull request (:pull:number
) has been addedWhat kind of change does this PR introduce?
pytest
version now thatxdoctest
supports it.xdoctest
supportingpytest~=8.0
.Does this PR introduce a breaking change?
No.
Other information:
FYI @RondeauG
The newest
pytest
(v8.0.0) introduced some regressions for Windows users. An issue is already up and a patch should arrive shortly (pytest-dev/pytest#11895). Until then, usepytest<8.0
on Windows.See also: pytest-dev/pytest#11969