Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest pytest and xdoctest #1632

Merged
merged 28 commits into from
Jul 31, 2024
Merged

Use latest pytest and xdoctest #1632

merged 28 commits into from
Jul 31, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jan 30, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features)
    • (If applicable) Documentation has been added / updated (for bug fixes / features)
  • CHANGES.rst has been updated (with summary of main changes)
    • Link to issue (:issue:number) and pull request (:pull:number) has been added

What kind of change does this PR introduce?

  • Unpins the pytest version now that xdoctest supports it.
  • Pins to the latest xdoctest supporting pytest~=8.0.

Does this PR introduce a breaking change?

No.

Other information:

FYI @RondeauG

The newest pytest (v8.0.0) introduced some regressions for Windows users. An issue is already up and a patch should arrive shortly (pytest-dev/pytest#11895). Until then, use pytest<8.0 on Windows.

See also: pytest-dev/pytest#11969

@Zeitsperre Zeitsperre self-assigned this Jan 30, 2024
@Zeitsperre
Copy link
Collaborator Author

The conda package is not yet available. Will re-run CI in a bit.

@github-actions github-actions bot added the approved Approved for additional tests label Jan 30, 2024
@Zeitsperre
Copy link
Collaborator Author

Looks like my namespace hack isn't working. I'll need to return to this next week.

@Zeitsperre
Copy link
Collaborator Author

Zeitsperre commented Feb 5, 2024

The latest pytest (v8.0.0) seems to have broken the conventional approach for injecting commands into the doctest namespace (used in the doctests).

Waiting to see what happens in pytest-dev/pytest#11929

Update: Fix was merged to the main development branch. Should be fixed in pytest v8.0.1

@Zeitsperre
Copy link
Collaborator Author

This functionality has been borked with 8.0.0 (See: pytest-dev/pytest#11873). No way of upgrading until a fix arrives.

@Zeitsperre
Copy link
Collaborator Author

The issue persists: pytest-dev/pytest#11884

@github-actions github-actions bot added CI Automation and Contiunous Integration indicators Climate indices and indicators labels Jul 30, 2024
Copy link

Note

It appears that this Pull Request modifies the main.yml workflow.

On inspection, the XCLIM_TESTDATA_BRANCH environment variable is set to the most recent tag (v2023.12.14).

No further action is required.

@coveralls
Copy link

coveralls commented Jul 30, 2024

Coverage Status

coverage: 89.384% (-1.0%) from 90.42%
when pulling 0c945db on unpin-pytest
into 7e4f7d9 on main.

@Zeitsperre
Copy link
Collaborator Author

This has been quite a day.

burn-elmo

Copy link
Collaborator

@aulemahal aulemahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Zeitsperre Zeitsperre merged commit da4a79a into main Jul 31, 2024
21 checks passed
@Zeitsperre Zeitsperre deleted the unpin-pytest branch July 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Approved for additional tests CI Automation and Contiunous Integration indicators Climate indices and indicators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants