-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROU-4883: change Markers to use new Google AdvancedMarker #181
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
JoaoFerreira-FrontEnd
approved these changes
Jul 3, 2024
OS-giulianasilva
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Google Maps API, google.maps.Marker, that we are currently using on OutSystemsMaps for markers was deprecated on February 21st 2024 and needs to be replaced with the new one,
google.maps.marker.AdvancedMarkerElement
.This will cause the warning above to appear, once the Google Maps script is updated to version
v3.56
and above.OutSystems Maps is currently using
v3.55
, that is available until November 2024.What was happening
Marker
class, but highly recommends to use the newAdvancedMarker
getAnimation
getClickable
getCursor
getDraggable
getIcon
getLabel
getMap
getOpacity
getPosition
getPosition
getShape
getTitle
getVisible
getZIndex
setAnimation
setClickable
setCursor
setDraggable
setIcon
setLabel
setMap
setOpacity
setOptions
setPosition
setShape
setTitle
setVisible
setZIndex
animation_changed
❌auxclick
✅clickable_changed
❌contextmenu
✅cursor_changed
❌dblclick
✅draggable_changed
❌flat_changed
❌icon_changed
❌mousedown
✅mouseout
✅mouseover
✅mouseup
✅position_changed
❌rightclick
✅shape_changed
❌title_changed
❌visible_changed
❌zindex_changed
❌What was done
AdvancedMarker
os-marker-icon
andos-marker-icon-label
auxclick
contextmenu
dblclick
mousedown
mouseout
mouseover
mouseup
rightclick
Test Steps
Checklist