Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11344: Adding files from OML #186

Merged
merged 3 commits into from
Nov 18, 2024
Merged

ROU-11344: Adding files from OML #186

merged 3 commits into from
Nov 18, 2024

Conversation

rugoncalves
Copy link
Contributor

@rugoncalves rugoncalves commented Nov 14, 2024

This PR is for adding the files that were until now just present in the OML. The files included are:

  • Leaflet.js
  • LeafletDraw.js
  • LeafletEditable.js
  • LeafletPathDrag.js
  • LeafletRoutingMachine.js
  • markerclusterer.js (google)
  • LeafletCSS.css
  • LeafletDrawCSS.css
  • LeafletRoutingCSS.css
  • ImagesCSS.css
  • MapCSS.css
  • TomTom.css (in OSMapsAutomation)
  • GraphHopper (in OSMapsAutomation)

What was happening

  • The files were being used in runtime, but were only stored in the OML, limiting the traceability of changed.

What was done

  • Added new folders to safe keep the files above (inside the src folder):
    • Files
      • Google
      • Internal
      • Leaflet
        • Directions
    • OSFramework (already existing)
    • OutSystems (already existing)
    • Providers (already existing)

Screenshots

image

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@rugoncalves rugoncalves added the documentation Improvements or additions to documentation label Nov 14, 2024
@rugoncalves rugoncalves requested a review from a team as a code owner November 14, 2024 12:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
56.1% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)
2 New Blocker Issues (required ≤ 0)
332 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@rugoncalves rugoncalves merged commit 27783ad into dev Nov 18, 2024
12 of 13 checks passed
@rugoncalves rugoncalves deleted the ROU-11344 branch November 18, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants