Add linux compatibility for wand_server #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux compatibility depends on HighFinesse NetAccess linux client installed on the machine running wand_server and HighFinesse wlmdataserver running on the machine also running the HighFinesse Instrument Server (see NetAccess manual for details).
This is needed by the artiq controller manager.
This makes sure there is a strong reference to the tasks so they don't get garbage collected.
|
Thanks for the contribution! I'm really happy to see this - I'd love to get rid of windows on our servers. I'll review later on and give feedback. |
Good catch - I hadn't appreciated that asyncio only stores weak references. c.f. https://docs.astral.sh/ruff/rules/asyncio-dangling-task/ That reminds me that ruff is a way better linter / formatter than flake8. I'll make an issue about moving this across. |
hartytp
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Ubuntu 22.04, python 3.10.12, wlmdata 7.264.2