updating for astropy6 #269
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #269 +/- ##
==========================================
+ Coverage 64.78% 64.81% +0.03%
==========================================
Files 14 14
Lines 1045 1046 +1
==========================================
+ Hits 677 678 +1
Misses 368 368 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
General comment: there quite a few changes in this, and probably only a few are relevant to fixing the bug. While I think it would be ok, a brief explanation for the extra changes might be nice.
Changes still needed: if you change the actions versions to v1 again, I think another deprecation warning will pop up, since github actions no longer runs on Node 12, but Node 16 instead. The old versions might not be compatible anymore with whatever version of Node github is using now under the hood. I recommend upgrading everything to v4, and seeing if it works.
tox.ini
Outdated
There was a problem hiding this comment.
I agree that this dependency coverage was probably overkill. As long as everything works with the newest version of everything, we should be good. Just recommend that people have an up to date environment. Then we just need to catch bugs as new versions arrive.
|
Looks like all the checks are passing. Ready for merge? |
|
Yes, ready to merge. So I will do such. |
Updates for astropy 6.0. Includes fixing the URL for the astropy developer docs.
Also updating the readthedocs and tox configurations.
Closes #268
Closes #271