Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev branch #300

Merged
merged 74 commits into from
Nov 1, 2024
Merged

Merge dev branch #300

merged 74 commits into from
Nov 1, 2024

Conversation

jdtsmith
Copy link
Contributor

@jdtsmith jdtsmith commented Nov 1, 2024

Merge the dev branch, which has been used to develop new units and bounds treatment, and introduce the new Fitter API.

Dries Van De Putte and others added 30 commits April 18, 2024 19:39
Partially masked arrays are not well supported, and required elaborate
workaround for pretty printing.  Here we use a structured array type,
and represent "fixed" bounds with np.nan instead of masking.  I.e. non
is interpreted as the same as negative or positive infinity, unless
both bound are nan, which indicates a fixed parameter.
A normal masked column using structured numpy arrays and nan for both
bounds when fixed now suffices.
Use importlib.resources instead of pkg_resources (from setuptools)
Dries Van De Putte and others added 28 commits May 20, 2024 16:54
Fitter API and make test cases work
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.89764% with 158 lines in your changes missing coverage. Please review.

Project coverage is 64.98%. Comparing base (171c645) to head (6f6ead0).

Files with missing lines Patch % Lines
pahfit/model.py 51.76% 109 Missing ⚠️
pahfit/features/features_format.py 16.66% 15 Missing ⚠️
pahfit/fitters/fitter.py 68.75% 10 Missing ⚠️
pahfit/fitters/ap_components.py 90.54% 7 Missing ⚠️
pahfit/fitters/ap_fitter.py 92.22% 7 Missing ⚠️
pahfit/features/features.py 84.37% 5 Missing ⚠️
pahfit/features/util.py 33.33% 4 Missing ⚠️
pahfit/scripts/plot_pahfit.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   64.30%   64.98%   +0.67%     
==========================================
  Files          14       16       +2     
  Lines        1073     1068       -5     
==========================================
+ Hits          690      694       +4     
+ Misses        383      374       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdtsmith jdtsmith merged commit ce18223 into master Nov 1, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants