Shaderc: Make non-semantic debug optional #11861
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weirdbeardgame
approved these changes
Oct 1, 2024
kamfretoz
force-pushed
the
shaderc-neutering
branch
from
b2b5974
to
003e176
Compare
|
|
kamfretoz
force-pushed
the
shaderc-neutering
branch
from
003e176
to
7568f5e
Compare
JordanTheToaster
approved these changes
Oct 3, 2024
Don't you hate it when you come up with more ideas just minutes AFTER the PR has been merged?
kamfretoz
force-pushed
the
shaderc-neutering
branch
from
7568f5e
to
c8ce455
Compare
F0bes
requested changes
Oct 3, 2024
There was a problem hiding this comment.
So, you've removed like 90% of the patch. The idea was to support the existing patch and an unpatched shaderc. Ideally you'd only change one line in the patch, the addition of #define SHADERC_PCSX2_CUSTOM 1.
You've removed shaderc_compilation_status_to_string and bunch of the shaderc_compile_into_xyz functions. If we're going this route a patched shaderc should be dropped outright. But that's not what I wanted to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR drops the hard requirement and the dependencies on the patched shaderc (so you can build PCSX2 without the patch if you choose to do so), whilst still reserving the patch for those who needs/wants it (non-semantic debug changes).
Rationale behind Changes
This should go along nicely with the package mode.
Suggested Testing Steps
See if the CI passes and nothing else broke.