FSUI: Don't move IMGUI cursor unnecessarily in DrawGameGrid() #11969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Move setting the cursor to the beginning of the Game Grid drawing loop.
Previously we would also set the cursor for the next item, even when we where the last item.
Rationale behind Changes
If the GameGrid was drawing an empty list, or a list where the number of grids was a multiple of the grid width, we would set the cursor onto a "grid line" with no entries.
In older versions of IMGUI, setting the cursor implicitly extended the parent's boundaries, this change was deprecated and only adding items would set the size. ocornut/imgui#5548
During this, an assert was added to detect the programs relying on this deprecated behaviour.
We trigger this assert when we move the cursor onto a new line, but leave it empty.
As the problem this PR addresses is minor, it should not block v2.2's release.
Suggested Testing Steps
Test Big Picture Mode's GameList, using the grid view