pdl_destroy to set pdl.sv IV to 0 not a random number

PDLPorters · Jun 2, 2024 · 1abaa36 · 1abaa36
1 parent 6bacfca
commit 1abaa36
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/Basic/Core/pdlapi.c b/Basic/Core/pdlapi.c
@@ -420,7 +420,7 @@ pdl_error pdl__destroy_recprotect(pdl *it, int recurse_count) {
     /* Clear the sv field so that there will be no dangling ptrs */
     if(it->sv) {
 	    mg_free((SV *)it->sv);
-	    sv_setiv(it->sv,0x4242);
+	    sv_setiv(it->sv, 0);
 	    it->sv = NULL;
     }
     /* 1. count the trans_children that do flow */

diff --git a/Changes b/Changes
@@ -3,6 +3,7 @@
 - fix treating a large Perl UV as an IV so getting sign wrong (#469)
 - remove obsolete $PP()
 - pptest.t now uses build dir to avoid noexec mount problems
+- on pdl_destroy, the sv member IV is set to 0 not a random number - thanks @fantasma13 for report
 
 2.089 2024-05-12
 - fix numerical misbehaviour in histogram etc on i686 (#474) - thanks @sebastic for report